Kafka
  1. Kafka
  2. KAFKA-91

zkclient does not show up in pom

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: packaging
    • Labels:
      None

      Description

      The pom from created by `make-pom`. Does not include zkclient, which is of course a key dependency. Not sure yet how to pull in zkclient while excluding sbt itself.

      $ cat core/target/scala_2.8.0/kafka-0.7.pom | grep -i zkclient | wc -l
      0

      1. k91-v1.txt
        2 kB
        Chris Burroughs
      2. k91-v2.txt
        2 kB
        Chris Burroughs

        Activity

        Hide
        Neha Narkhede added a comment -

        One way to do this would be to override the make-pom command in KafkaProject.scala and customize the output pom

        Show
        Neha Narkhede added a comment - One way to do this would be to override the make-pom command in KafkaProject.scala and customize the output pom
        Hide
        Chris Burroughs added a comment -

        Your right that's probably the best way instead of trying to do something clever and automatic with the contents of lib. Some examples I found: http://vasilrem.com/blog/software-development/from-sbt-to-maven-in-one-move/ , https://gist.github.com/878462

        Show
        Chris Burroughs added a comment - Your right that's probably the best way instead of trying to do something clever and automatic with the contents of lib. Some examples I found: http://vasilrem.com/blog/software-development/from-sbt-to-maven-in-one-move/ , https://gist.github.com/878462
        Hide
        Neha Narkhede added a comment -

        Moving it to 0.8

        Show
        Neha Narkhede added a comment - Moving it to 0.8
        Hide
        Chris Burroughs added a comment -

        This magic incantation appears to work.

        Show
        Chris Burroughs added a comment - This magic incantation appears to work.
        Hide
        Chris Burroughs added a comment -

        Could I get a review?

        Show
        Chris Burroughs added a comment - Could I get a review?
        Hide
        Neha Narkhede added a comment -

        Have we verified what other dependent jars this zkClient pulls in ? We've hit the multiple jar versions problem before.

        Show
        Neha Narkhede added a comment - Have we verified what other dependent jars this zkClient pulls in ? We've hit the multiple jar versions problem before.
        Hide
        Chris Burroughs added a comment -

        Our custom build of zkclient isn't in any repo and does not have a pom, so it can not pull in any dependencies.

        Show
        Chris Burroughs added a comment - Our custom build of zkclient isn't in any repo and does not have a pom, so it can not pull in any dependencies.
        Hide
        Neha Narkhede added a comment -

        Oh, I missed that. I tried to apply the patch, but it doesn't apply on a clean checkout of the repository. Could you rebase and upload it again ?

        Show
        Neha Narkhede added a comment - Oh, I missed that. I tried to apply the patch, but it doesn't apply on a clean checkout of the repository. Could you rebase and upload it again ?
        Hide
        Chris Burroughs added a comment -

        Sorry missed your reply, rebased as of 76957e5e3a748b59525e5e7934f93721eb8f4c38

        Show
        Chris Burroughs added a comment - Sorry missed your reply, rebased as of 76957e5e3a748b59525e5e7934f93721eb8f4c38
        Hide
        Neha Narkhede added a comment -

        +1. Just committed this, but realized you could've done it yourself.

        Show
        Neha Narkhede added a comment - +1. Just committed this, but realized you could've done it yourself.

          People

          • Assignee:
            Chris Burroughs
            Reporter:
            Chris Burroughs
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development