Kafka
  1. Kafka
  2. KAFKA-907

controller needs to close socket channel to brokers on exception

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      When the controller sends a request to a broker (e.g., leaderAndIsrRequest), it may hit a exception (e.g. SocketTimeException). When this happens, the socket channel needs to be closed and recreated.

        Activity

        Hide
        Jun Rao added a comment -

        Thanks for the review. Addressed the comment and committed to 0.8.

        Show
        Jun Rao added a comment - Thanks for the review. Addressed the comment and committed to 0.8.
        Hide
        Neha Narkhede added a comment -

        Thanks for the patch. The following if statement is unnecessary since that condition gets checked in the connect() API of BlockingChannel.

        if(!channel.isConnected)

        { channel.connect() }

        Other than that, +1

        Show
        Neha Narkhede added a comment - Thanks for the patch. The following if statement is unnecessary since that condition gets checked in the connect() API of BlockingChannel. if(!channel.isConnected) { channel.connect() } Other than that, +1
        Hide
        Jun Rao added a comment -

        Attach a patch.

        Show
        Jun Rao added a comment - Attach a patch.

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development