[KAFKA-8945] Incorrect null check in the constructor for ConnectorHealth and AbstractState

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.0.2, 2.1.2, 2.2.2, 2.4.0, 2.5.0, 2.3.2
• Component/s: connect
• Labels: kafka-connect rest_api
• Flags: Patch
• Assignee: Chris Egerton
• Reporter: Sanjana Kaundinya
• Reviewer: Randall Hauch
• Created: 25/Sep/19 23:09
• Updated: 16/Oct/19 20:59
• Resolved: 15/Oct/19 23:02

Description

This bug is in relation to KIP-285: https://cwiki.apache.org/confluence/display/KAFKA/KIP-285%3A+Connect+Rest+Extension+Plugin

In the constructors of ConnectorHealth.java and AbstractState.java, the check that is done for the null parameters is done incorrectly. The current code only allows for the class to be instantiated if the parameters passed in are null. However the expected behavior has to be the opposite of this: we only want this class to be instantiated if the parameters passed in are not null. While the fix for this is pretty trivial, it would be good to add in some testing that tests the appropriate classes related to the rest extension.

Issue Links

• is related to: KAFKA-8947 Connect framework incorrectly instantiates TaskStates for REST extensions
• links to: GitHub Pull Request #7392
• links to: GitHub Pull Request #7524
• links to: GitHub Pull Request #7533