[KAFKA-8899] Optimize Partition.maybeIncrementLeaderHW

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.3.0, 2.2.1
• Component/s: core
• Assignee: Unassigned
• Reporter: Lucas Bradstreet
• Created: 11/Sep/19 21:25
• Updated: 12/Sep/19 23:17
• Resolved: 12/Sep/19 23:17

Description

Partition.maybeIncrementLeaderHW is in the hot path for ReplicaManager.updateFollowerFetchState. When replicating between brokers with high partition counts, maybeIncrementLeaderHW becomes expensive, with much of the time going to calling Partition.remoteReplicas which performs a toSet conversion. maybeIncrementLeaderHW should avoid generating any intermediate collections when calculating the new HWM.

Issue Links

• links to: GitHub Pull Request #7324