Kafka
  1. Kafka
  2. KAFKA-887

Standardize logging for partition information to [%s,%d] format

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      We have many ways of printing log4j information for partitions making it very difficult to trace a particular partition through some log4j logs.

      1. kafka-887.patch
        25 kB
        Neha Narkhede

        Activity

        Neha Narkhede created issue -
        Neha Narkhede made changes -
        Field Original Value New Value
        Description We have many ways of printing log4j information for partitions making it very difficult to trace a particular partition through some log4j logs. This patch has 2 changes -

        1. Standardize on "partition [%s,%d]"
        2. In Partition.scala, the list of stuck/slow replicas was printed even if it was empty. Improved it to print only if the list has at least 1 item.
        We have many ways of printing log4j information for partitions making it very difficult to trace a particular partition through some log4j logs.
        Hide
        Neha Narkhede added a comment -

        This patch has 2 changes -

        1. Standardize on "partition [%s,%d]"
        2. In Partition.scala, the list of stuck/slow replicas was printed even if it was empty. Improved it to print only if the list has at least 1 item.

        Show
        Neha Narkhede added a comment - This patch has 2 changes - 1. Standardize on "partition [%s,%d] " 2. In Partition.scala, the list of stuck/slow replicas was printed even if it was empty. Improved it to print only if the list has at least 1 item.
        Neha Narkhede made changes -
        Attachment kafka-887.patch [ 12581002 ]
        Hide
        Swapnil Ghike added a comment -

        Thanks for the cleanup. +1

        Show
        Swapnil Ghike added a comment - Thanks for the cleanup. +1
        Hide
        Neha Narkhede added a comment -

        Thanks for the quick review, Swapnil. Can I also get a review from some committer ?

        Show
        Neha Narkhede added a comment - Thanks for the quick review, Swapnil. Can I also get a review from some committer ?
        Hide
        Jun Rao added a comment -

        Thanks for the patch. +1.

        Show
        Jun Rao added a comment - Thanks for the patch. +1.
        Neha Narkhede made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Neha Narkhede added a comment -

        Thanks for the reviews, committed to 0.8

        Show
        Neha Narkhede added a comment - Thanks for the reviews, committed to 0.8
        Neha Narkhede made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Neha Narkhede
            Reporter:
            Neha Narkhede
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development