These are not needed and conflict with the API documentation. Should be removed to be consistent with other APIs
Sorry for lagging on this. Committed.
Meant "diff" not "patch"
v2 of patch rebased against current trunk.
Sorry for the late review. The patch no longer applies to trunk. Could you rebase? Thanks,
The responses should include correlation, but not client id. The client id is just used for logging purposes on the broker, but correlation is used for clients to do async request/response handling. From the protocol wiki page: "Response => CorrelationId ResponseMessage"
I had incorrectly included the client id in these two new responses (I originally was including version id as well, which was also a mistake - KAFKA-759).
I think you meant to remove correlation id right ?
@Neha, I attached a diff created using git-diff. The previous patch was generated using git format-patch.
Also, this issue is targeting 0.8.1 (which I'm assuming is trunk) not 0.8. The Offset fetch/commit APIs are not slated for the 0.8 release AFAIK
Thanks for the patch, David. However, I'm not able to apply it using the following commands -
patch -p1 kafka-852.patch
patch -p0 kafka-852.patch
Please create a patch using the following command -
git diff <local-0.8-branch> > kafka-852.patch
git remote update
git diff origin/0.8 > kafka-852.patch
v1 of patch attached, simple change