Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: clients
    • Labels:
      None

      Description

      • Refactoring original .NET client to mimic low-level and high-level Java APIs
      • ZooKeeper support for producers / consumers
      • Partitioner support for producers
      • Custom encoders for producers
      • Integration tests
      1. KAFKA-85.patch
        2.06 MB
        Eric Hauser
      2. KAFKA-85_2.patch
        109 kB
        Eric Hauser

        Activity

        Hide
        Eric Hauser added a comment -

        Create using:

        git diff --no-prefix a6ea8b16a11ad3fff6a283bface5c14975caec2d..be7bc445becd945be84365589574936db66d9399 > KAKFA-85.patch

        against:

        git@github.com:ExactTargetDev/kafka.git - dotnet-client-enhancements

        Show
        Eric Hauser added a comment - Create using: git diff --no-prefix a6ea8b16a11ad3fff6a283bface5c14975caec2d..be7bc445becd945be84365589574936db66d9399 > KAKFA-85.patch against: git@github.com:ExactTargetDev/kafka.git - dotnet-client-enhancements
        Hide
        Jun Rao added a comment -

        Could you rebase your patch off the Apache repository? I can't seem to apply the patch.

        patching file .gitignore
        Hunk #1 FAILED at 9.
        1 out of 1 hunk FAILED – saving rejects to file .gitignore.rej
        The next patch would delete the file clients/csharp/lib/StyleCop/Microsoft.StyleCop.Targets,
        which does not exist! Assume -R? [n] ^C

        Show
        Jun Rao added a comment - Could you rebase your patch off the Apache repository? I can't seem to apply the patch. patching file .gitignore Hunk #1 FAILED at 9. 1 out of 1 hunk FAILED – saving rejects to file .gitignore.rej The next patch would delete the file clients/csharp/lib/StyleCop/Microsoft.StyleCop.Targets, which does not exist! Assume -R? [n] ^C
        Hide
        Eric Hauser added a comment -

        Will do as soon as there is a GitHub mirror.

        Show
        Eric Hauser added a comment - Will do as soon as there is a GitHub mirror.
        Hide
        Chris Burroughs added a comment -

        Eric, git://git.apache.org/kafka.git mirror is now up.

        Show
        Chris Burroughs added a comment - Eric, git://git.apache.org/kafka.git mirror is now up.
        Hide
        Eric Hauser added a comment -

        I went ahead and created a patch against SVN to make sure it applies correctly. Attached is the new version.

        Show
        Eric Hauser added a comment - I went ahead and created a patch against SVN to make sure it applies correctly. Attached is the new version.
        Hide
        Eric Hauser added a comment -

        Just wanted to add the following relevant task:

        https://issues.apache.org/jira/browse/INFRA-3842

        The ZooKeeper project has asked for Windows build support for Jenkins so that the ZK C# client can be built with CI. The C# ZK client used in the Kafka patch has been contributed to the ZooKeeper project as well:

        https://issues.apache.org/jira/browse/ZOOKEEPER-1158

        Show
        Eric Hauser added a comment - Just wanted to add the following relevant task: https://issues.apache.org/jira/browse/INFRA-3842 The ZooKeeper project has asked for Windows build support for Jenkins so that the ZK C# client can be built with CI. The C# ZK client used in the Kafka patch has been contributed to the ZooKeeper project as well: https://issues.apache.org/jira/browse/ZOOKEEPER-1158
        Hide
        Jun Rao added a comment -

        Thanks for the patch, Eric.

        This is a big patch and it's a lot of work. It raised a good question: what's the right approach to support client bindings for languages other than java. I will start a discussion in our mailing list.

        Show
        Jun Rao added a comment - Thanks for the patch, Eric. This is a big patch and it's a lot of work. It raised a good question: what's the right approach to support client bindings for languages other than java. I will start a discussion in our mailing list.
        Hide
        Jun Rao added a comment -

        Eric, are you serious about maintaining the .net client going forward? If so, I can commit your patch for now. Thanks,

        Show
        Jun Rao added a comment - Eric, are you serious about maintaining the .net client going forward? If so, I can commit your patch for now. Thanks,
        Hide
        Eric Hauser added a comment -

        We are certainly using it, and have already implemented compression and a number of performance fixes that I'll be submitting in additional patches.

        Show
        Eric Hauser added a comment - We are certainly using it, and have already implemented compression and a number of performance fixes that I'll be submitting in additional patches.
        Hide
        Jun Rao added a comment -

        Do you really need clients/csharp/lib/log4Net/log4net.xml? It's a pretty big file.

        Show
        Jun Rao added a comment - Do you really need clients/csharp/lib/log4Net/log4net.xml? It's a pretty big file.
        Hide
        Eric Hauser added a comment -

        No, that does not need to be committed.

        Show
        Eric Hauser added a comment - No, that does not need to be committed.
        Hide
        Jun Rao added a comment -

        Committed without the xml file. Thanks Eric.

        Show
        Jun Rao added a comment - Committed without the xml file. Thanks Eric.
        Hide
        Jun Rao added a comment -

        Eric, could you fix all the headers to comply with Apache format? Thanks,

        Show
        Jun Rao added a comment - Eric, could you fix all the headers to comply with Apache format? Thanks,
        Hide
        Eric Hauser added a comment -

        Attached a patch that adds the headers. This is the previous full patch minus the XML file.

        Show
        Eric Hauser added a comment - Attached a patch that adds the headers. This is the previous full patch minus the XML file.
        Hide
        Jun Rao added a comment -

        Eric, I already committed your first patch. Could you make a patch that includes just the header change? Please make the header identical to other scala files. For example, please don't include "Copyright 2011 LinkedIn". Thanks,

        Show
        Jun Rao added a comment - Eric, I already committed your first patch. Could you make a patch that includes just the header change? Please make the header identical to other scala files. For example, please don't include "Copyright 2011 LinkedIn". Thanks,
        Hide
        Eric Hauser added a comment -

        Sure, will do. Apparently the GitHub sync is a little behind. I didn't see your commit out there so I just assumed you hadn't committed it yet.

        Show
        Eric Hauser added a comment - Sure, will do. Apparently the GitHub sync is a little behind. I didn't see your commit out there so I just assumed you hadn't committed it yet.
        Hide
        Alan Cabrera added a comment -

        What is the "GitHub" sync?

        Show
        Alan Cabrera added a comment - What is the "GitHub" sync?
        Hide
        Eric Hauser added a comment -

        All ASF repositories are synced to GitHub as read only mirrors:

        http://git.apache.org/
        https://github.com/apache/kafka

        Show
        Eric Hauser added a comment - All ASF repositories are synced to GitHub as read only mirrors: http://git.apache.org/ https://github.com/apache/kafka

          People

          • Assignee:
            Unassigned
            Reporter:
            Eric Hauser
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development