git diff --no-prefix a6ea8b16a11ad3fff6a283bface5c14975caec2d..be7bc445becd945be84365589574936db66d9399 > KAKFA-85.patch
firstname.lastname@example.org:ExactTargetDev/kafka.git - dotnet-client-enhancements
Could you rebase your patch off the Apache repository? I can't seem to apply the patch.
patching file .gitignore
Hunk #1 FAILED at 9.
1 out of 1 hunk FAILED – saving rejects to file .gitignore.rej
The next patch would delete the file clients/csharp/lib/StyleCop/Microsoft.StyleCop.Targets,
which does not exist! Assume -R? [n] ^C
Will do as soon as there is a GitHub mirror.
Eric, git://git.apache.org/kafka.git mirror is now up.
I went ahead and created a patch against SVN to make sure it applies correctly. Attached is the new version.
Just wanted to add the following relevant task:
The ZooKeeper project has asked for Windows build support for Jenkins so that the ZK C# client can be built with CI. The C# ZK client used in the Kafka patch has been contributed to the ZooKeeper project as well:
Thanks for the patch, Eric.
This is a big patch and it's a lot of work. It raised a good question: what's the right approach to support client bindings for languages other than java. I will start a discussion in our mailing list.
Eric, are you serious about maintaining the .net client going forward? If so, I can commit your patch for now. Thanks,
We are certainly using it, and have already implemented compression and a number of performance fixes that I'll be submitting in additional patches.
Do you really need clients/csharp/lib/log4Net/log4net.xml? It's a pretty big file.
No, that does not need to be committed.
Committed without the xml file. Thanks Eric.
Eric, could you fix all the headers to comply with Apache format? Thanks,
Attached a patch that adds the headers. This is the previous full patch minus the XML file.
Eric, I already committed your first patch. Could you make a patch that includes just the header change? Please make the header identical to other scala files. For example, please don't include "Copyright 2011 LinkedIn". Thanks,
Sure, will do. Apparently the GitHub sync is a little behind. I didn't see your commit out there so I just assumed you hadn't committed it yet.
What is the "GitHub" sync?
All ASF repositories are synced to GitHub as read only mirrors: