Kafka
  1. Kafka
  2. KAFKA-846

AbstractFetcherThread should do shallow instead of deep iteration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:
      None

      Description

      Deep iteration does decompression, which introduces unnecessary overhead.

        Activity

        Jun Rao created issue -
        Hide
        Jun Rao added a comment -

        Attach a patch.

        Show
        Jun Rao added a comment - Attach a patch.
        Jun Rao made changes -
        Field Original Value New Value
        Attachment kafka-846.patch [ 12576795 ]
        Jun Rao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.8 [ 12317244 ]
        Hide
        Neha Narkhede added a comment -

        Thanks for the patch! +1
        Minor comment => Typo -> parititon in AbstractFetcherThread

        Show
        Neha Narkhede added a comment - Thanks for the patch! +1 Minor comment => Typo -> parititon in AbstractFetcherThread
        Hide
        Jun Rao added a comment -

        Thanks for the review. Committed to 0.8 after fixing the typo. Also fixed an issue with type mismatch in the logging statement.

        Show
        Jun Rao added a comment - Thanks for the review. Committed to 0.8 after fixing the typo. Also fixed an issue with type mismatch in the logging statement.
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development