Kafka
  1. Kafka
  2. KAFKA-827

improve list topic output format

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:
      None

      Description

      We need to make the output of list topic command more readable.

      1. kafk-827_v3.patch
        2 kB
        Jun Rao
      2. kafka-827_v2.patch
        2 kB
        Jun Rao
      3. kafka-827.patch
        2 kB
        Jun Rao

        Activity

        Jun Rao created issue -
        Hide
        Jun Rao added a comment -

        Attach a patch.

        Show
        Jun Rao added a comment - Attach a patch.
        Jun Rao made changes -
        Field Original Value New Value
        Attachment kafka-827.patch [ 12575531 ]
        Jun Rao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Joel Koshy added a comment -

        While you are touching this, would it be reasonable to also switch from using the AdminUtil to a blank TopicMetadataRequest? It runs a lot quicker if there are a large number of topics and you run the tool from outside the ZK cluster's DC. Also, the topicOpt description has been misleading for a while.

        Show
        Joel Koshy added a comment - While you are touching this, would it be reasonable to also switch from using the AdminUtil to a blank TopicMetadataRequest? It runs a lot quicker if there are a large number of topics and you run the tool from outside the ZK cluster's DC. Also, the topicOpt description has been misleading for a while.
        Hide
        Jay Kreps added a comment -

        This is already done on trunk, please backport that.

        Show
        Jay Kreps added a comment - This is already done on trunk, please backport that.
        Hide
        Jun Rao added a comment -

        Attach patch v2.

        1. Back ported the fix from trunk and made a slight change to print each partition in a single line.
        2. Fixed the description of the topic option.
        3. Didn't make the change to use TopicMetadataRequest since it's not a blocker. Also, in trunk, list topic is merged into a single tool that requires ZK.

        Show
        Jun Rao added a comment - Attach patch v2. 1. Back ported the fix from trunk and made a slight change to print each partition in a single line. 2. Fixed the description of the topic option. 3. Didn't make the change to use TopicMetadataRequest since it's not a blocker. Also, in trunk, list topic is merged into a single tool that requires ZK.
        Jun Rao made changes -
        Attachment kafka-827_v2.patch [ 12576189 ]
        Hide
        Neha Narkhede added a comment -

        Overall, good change. 2 suggestions -

        1. Can we not make this change as part of overriding the toString() API of PartitionMetadata ?
        2. For the ease of scripting, please can we
        2.1 reduce 2 tabs to 1 tab ?
        2.2 remove the space after the comma ?

        Show
        Neha Narkhede added a comment - Overall, good change. 2 suggestions - 1. Can we not make this change as part of overriding the toString() API of PartitionMetadata ? 2. For the ease of scripting, please can we 2.1 reduce 2 tabs to 1 tab ? 2.2 remove the space after the comma ?
        Hide
        Jun Rao added a comment -

        Thanks for the review. These are good suggestions. Attach patch v3 that addresses those issues.

        Show
        Jun Rao added a comment - Thanks for the review. These are good suggestions. Attach patch v3 that addresses those issues.
        Jun Rao made changes -
        Attachment kafk-827_v3.patch [ 12576404 ]
        Hide
        Neha Narkhede added a comment -

        Looks great, thanks for the patch !
        +1

        Show
        Neha Narkhede added a comment - Looks great, thanks for the patch ! +1
        Hide
        Jun Rao added a comment -

        Thanks for the review. Committed to 0.8.

        Show
        Jun Rao added a comment - Thanks for the review. Committed to 0.8.
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.8 [ 12317244 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development