Kafka
  1. Kafka
  2. KAFKA-812

Support deep iteration in DumpLogSegments tool

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: tools
    • Labels:
      None

      Description

      Currently, DumpLogSegments only supports shallow iteration. This makes it hard to verify index consistency in system tests.

        Activity

        Jun Rao created issue -
        Jun Rao made changes -
        Field Original Value New Value
        Attachment kafka-812.patch [ 12574283 ]
        Jun Rao made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Jun Rao added a comment -

        Attach a patch. The patch only enables deep iteration in DumpLogSegments itself.

        Thought about adding deep iteration in FileMessageSet itself. Decided not to do that because (1) currently, only DumpLogSegments tool iterates FileMessageSet; (2) would like to reuse the iterator code in ByteBufferMessageSet and it doesn't seem to be easy. So, it's probably better to revisit this in trunk.

        Show
        Jun Rao added a comment - Attach a patch. The patch only enables deep iteration in DumpLogSegments itself. Thought about adding deep iteration in FileMessageSet itself. Decided not to do that because (1) currently, only DumpLogSegments tool iterates FileMessageSet; (2) would like to reuse the iterator code in ByteBufferMessageSet and it doesn't seem to be easy. So, it's probably better to revisit this in trunk.
        Jun Rao made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Hide
        Neha Narkhede added a comment -

        Looks good, +1. Please can you fix some code style inconsistencies -

        1. there is no space after = in some places in this tool
        2. inconsistent indentation on the option parsing

        Show
        Neha Narkhede added a comment - Looks good, +1. Please can you fix some code style inconsistencies - 1. there is no space after = in some places in this tool 2. inconsistent indentation on the option parsing
        Hide
        Jun Rao added a comment -

        Thanks for the review. Committed to 0.8 with the suggested fix.

        Show
        Jun Rao added a comment - Thanks for the review. Committed to 0.8 with the suggested fix.
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.8 [ 12317244 ]
        Resolution Fixed [ 1 ]
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development