Kafka
  1. Kafka
  2. KAFKA-80

Fork or create link to node kafka client

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: clients
    • Labels:

      Description

      https://github.com/marcuswestin/node-kafka has a working implementation of simple client in nodejs. It would be nice if it can be listed among the known kafka clients to avoid reinventing the wheel if someone needs a node implementation.

      Cheers!
      Marcus

        Activity

        Marcus Westin created issue -
        Alan Cabrera made changes -
        Field Original Value New Value
        Workflow jira [ 12626029 ] no-reopen-closed, patch-avail [ 12626216 ]
        Hide
        Chris Burroughs added a comment -

        Marcus I'm not sure what you mean by fork. Are you requesting that we include this in the main Kafka tree (in which case ASF policy would require you to attach it at a patch and click the legal checkbox), or would you prefer to have just a link in the README & wiki and manage the code yourself on github?

        Show
        Chris Burroughs added a comment - Marcus I'm not sure what you mean by fork. Are you requesting that we include this in the main Kafka tree (in which case ASF policy would require you to attach it at a patch and click the legal checkbox), or would you prefer to have just a link in the README & wiki and manage the code yourself on github?
        Hide
        Marcus Westin added a comment -

        Hey Chris,

        Whichever is the project maintainers' preference. If you like to have the clients in the kafka tree then I'll submit it as a patch; if not then a link in the README sounds great too.

        Cheers!

        Show
        Marcus Westin added a comment - Hey Chris, Whichever is the project maintainers' preference. If you like to have the clients in the kafka tree then I'll submit it as a patch; if not then a link in the README sounds great too. Cheers!
        Hide
        Jay Kreps added a comment -

        Hi Marcus, thanks for the great contribution!

        I think if the code is in reasonably good shape we prefer to keep it with the main code base unless you are doing very active development and would prefer to have your own repo. This helps people find the code, send us patches, and will help us to add integration tests that run all the clients against the server.

        One thing we need to be able to do this though is make sure we have someone who will maintain the code on an ongoing basis (adapt to any binary format changes, fix bugs, etc). If you are up for doing that then I would vote we keep it with the main code.

        Show
        Jay Kreps added a comment - Hi Marcus, thanks for the great contribution! I think if the code is in reasonably good shape we prefer to keep it with the main code base unless you are doing very active development and would prefer to have your own repo. This helps people find the code, send us patches, and will help us to add integration tests that run all the clients against the server. One thing we need to be able to do this though is make sure we have someone who will maintain the code on an ongoing basis (adapt to any binary format changes, fix bugs, etc). If you are up for doing that then I would vote we keep it with the main code.
        Hide
        Marcus Westin added a comment -

        Yeah, if protocol changes are described well and there's working example code I'm happy to keep the node client up to date. Ok, I'll get a formal patch together.

        Cheers!
        Marcus

        Show
        Marcus Westin added a comment - Yeah, if protocol changes are described well and there's working example code I'm happy to keep the node client up to date. Ok, I'll get a formal patch together. Cheers! Marcus
        Hide
        Colin B. added a comment -

        There is a link to the Node.JS client on the wiki page.
        https://cwiki.apache.org/confluence/display/KAFKA/Clients#Clients-Node.js

        This bug should be closed as fixed.

        Show
        Colin B. added a comment - There is a link to the Node.JS client on the wiki page. https://cwiki.apache.org/confluence/display/KAFKA/Clients#Clients-Node.js This bug should be closed as fixed.
        Marcus Westin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Jun Rao made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Marcus Westin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development