[KAFKA-809] Dependency on zkclient 0.1 (redundant) prevents building in IntelliJ

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 0.8.0
• Fix Version/s: 0.8.0
• Labels: build patch
• Assignee: Dragos Manolescu
• Reporter: Dragos Manolescu
• Created: 15/Mar/13 20:20
• Updated: 04/Apr/13 16:58
• Resolved: 04/Apr/13 16:58

Description

Per email thread from 3/14/2013; patch with fix included at the end of the description.

Thanks for looking into this, Dragos. We should remove ""com.github.sgroschupf"
% "zkclient" % "0.1"," from the build.sbt files. Would you like to
create a JIRA and/or attach a patch ?

-Neha

On Thu, Mar 14, 2013 at 5:21 PM, Dragos Manolescu <
[e-mail]> wrote:

I dug into this and found a problem. The kafka build files show
dependencies on two different versions of the zkclient code:

In core/build.sbt:

libraryDependencies ++= Seq(
"org.apache.zookeeper" % "zookeeper" % "3.3.4",
"com.github.sgroschupf" % "zkclient" % "0.1",
"org.xerial.snappy" % "snappy-java" % "1.0.4.1",
"org.easymock" % "easymock" % "3.0" % "test",
"junit" % "junit" % "4.1" % "test"
)

And in project/Build.scala:

// POM Tweaking for core:
def zkClientDep =
<dependency>
<groupId>zkclient</groupId>
<artifactId>zkclient</artifactId>
<version>20120522</version>
<scope>compile</scope>
</dependency>

In version 0.1 of com.github.sgroschupf.ZkClient (listed in build.sbt)
writeData doesn't return anything (http://j.mp/XBnn5g), which causes the
compile error from my initial message (see below); that changed in 0.2
(http://j.mp/WqUx4x).

zkclient-20120522 (listed in Build.scala) is checked in as a JAR in the
core/lib folder (http://j.mp/10U4XgE).

I haven't researched why between sbt and IntelliJ ZkClient resolves
differently, and don't know the history behind the "POM tweaking" comment
above. I was able to build Kafka in IntelliJ by removing the reference to
com.github.sgroschupf.ZkClient. Perhaps this is a leftover from 0.7.2 (I
if I recall correctly it depends on 0.1)?

At any rate if anybody runs into similar problems when building in InteliJ
I hope that this fix addresses them. Comments welcome.

Thanks,

-Dragos

Index: core/build.sbt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
Subsystem: com.intellij.openapi.diff.impl.patch.BaseRevisionTextPatchEP
<>import sbt.\nimport Keys.\n\nname := \"kafka\"\n\nresolvers ++= Seq(\n \"SonaType ScalaTest repo\" at \"https://oss.sonatype.org/content/groups/public/org/scalatest/\"\n)\n\nlibraryDependencies <= scalaVersion(\"org.scala-lang\" % \"scala-compiler\" % _ )\n\nlibraryDependencies += Seq(\n \"org.apache.zookeeper\" % \"zookeeper\" % \"3.3.4\",\n \"com.github.sgroschupf\" % \"zkclient\" % \"0.1\",\n \"org.xerial.snappy\" % \"snappy-java\" % \"1.0.4.1\",\n \"org.easymock\" % \"easymock\" % \"3.0\" % \"test\",\n \"junit\" % \"junit\" % \"4.1\" % \"test\"\n)\n\nlibraryDependencies <<= (scalaVersion, libraryDependencies) { (sv, deps) =>\n deps : (sv match

{\n case \"2.8.0\" => \"org.scalatest\" % \"scalatest\" % \"1.2\" % \"test\"\n case _ => \"org.scalatest\" %% \"scalatest\" % \"1.8\" % \"test\"\n }

)\n}\n\n\n
===================================================================
— core/build.sbt (revision 3b3fb7fed622cc0339c3b9e3fb175e6093e427a3)
+++ core/build.sbt (revision )
@@ -11,7 +11,6 @@

libraryDependencies ++= Seq(
"org.apache.zookeeper" % "zookeeper" % "3.3.4",

• "com.github.sgroschupf" % "zkclient" % "0.1",
  "org.xerial.snappy" % "snappy-java" % "1.0.4.1",
  "org.easymock" % "easymock" % "3.0" % "test",
  "junit" % "junit" % "4.1" % "test"