Kafka
  1. Kafka
  2. KAFKA-798

Use biased histograms instead of uniform histograms in KafkaMetricsGroup

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:

      Description

      A biased histogram produces quantiles which are representative of (roughly) the last five minutes of data. On the other hand, a uniform histogram produces quantiles which are valid for the entirely of the histogram’s lifetime. More discussion at http://metrics.codahale.com/manual/core/#man-core-histograms-uniform

      1. kafka-798.patch
        0.8 kB
        Swapnil Ghike

        Activity

        Hide
        Swapnil Ghike added a comment -

        One word fix.

        Show
        Swapnil Ghike added a comment - One word fix.
        Hide
        Neha Narkhede added a comment -

        +1, thanks for catching the problem and fixing it!

        Show
        Neha Narkhede added a comment - +1, thanks for catching the problem and fixing it!
        Hide
        Neha Narkhede added a comment -

        Fix is checked in to 0.8

        Show
        Neha Narkhede added a comment - Fix is checked in to 0.8
        Hide
        Jun Rao added a comment -

        Thanks for the patch. What about Timer? Does it include a biased histogram?

        Show
        Jun Rao added a comment - Thanks for the patch. What about Timer? Does it include a biased histogram?
        Hide
        Swapnil Ghike added a comment -

        Yes, timer includes a biased histogram by default.

        Show
        Swapnil Ghike added a comment - Yes, timer includes a biased histogram by default.

          People

          • Assignee:
            Swapnil Ghike
            Reporter:
            Swapnil Ghike
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development