Kafka
  1. Kafka
  2. KAFKA-798

Use biased histograms instead of uniform histograms in KafkaMetricsGroup

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:

      Description

      A biased histogram produces quantiles which are representative of (roughly) the last five minutes of data. On the other hand, a uniform histogram produces quantiles which are valid for the entirely of the histogram’s lifetime. More discussion at http://metrics.codahale.com/manual/core/#man-core-histograms-uniform

      1. kafka-798.patch
        0.8 kB
        Swapnil Ghike

        Activity

        Swapnil Ghike created issue -
        Hide
        Swapnil Ghike added a comment -

        One word fix.

        Show
        Swapnil Ghike added a comment - One word fix.
        Swapnil Ghike made changes -
        Field Original Value New Value
        Attachment kafka-798.patch [ 12572878 ]
        Hide
        Neha Narkhede added a comment -

        +1, thanks for catching the problem and fixing it!

        Show
        Neha Narkhede added a comment - +1, thanks for catching the problem and fixing it!
        Neha Narkhede made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Neha Narkhede added a comment -

        Fix is checked in to 0.8

        Show
        Neha Narkhede added a comment - Fix is checked in to 0.8
        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Jun Rao added a comment -

        Thanks for the patch. What about Timer? Does it include a biased histogram?

        Show
        Jun Rao added a comment - Thanks for the patch. What about Timer? Does it include a biased histogram?
        Hide
        Swapnil Ghike added a comment -

        Yes, timer includes a biased histogram by default.

        Show
        Swapnil Ghike added a comment - Yes, timer includes a biased histogram by default.
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        21h 33m 1 Neha Narkhede 09/Mar/13 22:53
        Resolved Resolved Closed Closed
        9s 1 Neha Narkhede 09/Mar/13 22:53

          People

          • Assignee:
            Swapnil Ghike
            Reporter:
            Swapnil Ghike
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development