Kafka
  1. Kafka
  2. KAFKA-793

Include controllerId in all requests sent by controller

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:

      Description

      As part of KAFKA-513, we added controllerId in LeaderAndIsrRequest. We should add that to all requests sent by the controller, such as StopReplicaRequest.

      Other small issues that can be taken care of by this jira:
      1. The string "state.change.logger" is used in many places. We should create a constant val and reuse the val to avoid human mistakes.
      2. Remove the private constructor from ControllerChannelManager.
      3. Remove default from jsonFileOpt in PreferredReplicaLeaderElectionCommand, because the default is only used to indicate an absense of a legitimate jsonFile. We can check the same using if(options.has(jsonFileOpt))

      1. kafka-793-v1.patch
        13 kB
        Swapnil Ghike

        Activity

        Neha Narkhede made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jun Rao made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jun Rao added a comment -

        Thanks for the patch. +1. Committed to 0.8.

        Show
        Jun Rao added a comment - Thanks for the patch. +1. Committed to 0.8.
        Swapnil Ghike made changes -
        Attachment kafka-793-v1.patch [ 12572662 ]
        Hide
        Swapnil Ghike added a comment -

        Patch v1. Created a val for "state.change.logger" in KafkaController object.

        Show
        Swapnil Ghike added a comment - Patch v1. Created a val for "state.change.logger" in KafkaController object.
        Swapnil Ghike made changes -
        Assignee Swapnil Ghike [ swapnilghike ]
        Swapnil Ghike made changes -
        Field Original Value New Value
        Labels kafka-0.8 p1
        Swapnil Ghike created issue -

          People

          • Assignee:
            Swapnil Ghike
            Reporter:
            Swapnil Ghike
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development