[KAFKA-7532] Missing stringification in error message "Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController)"

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.2.0, 2.1.1, 2.0.2
• Component/s: controller
• Assignee: Stanislav Kozlovski
• Reporter: Andreas Kohn
• Created: 23/Oct/18 12:56
• Updated: 26/Oct/18 13:50
• Resolved: 26/Oct/18 13:50

Description

Messages I saw in my logs:

[2018-10-23 12:19:59,975] INFO [RequestSendThread controllerId=0] Shutting down (kafka.controller.RequestSendThread)
[2018-10-23 12:19:59,975] INFO [RequestSendThread controllerId=0] Stopped (kafka.controller.RequestSendThread)
[2018-10-23 12:19:59,975] INFO [RequestSendThread controllerId=0] Shutdown completed (kafka.controller.RequestSendThread)
[2018-10-23 12:19:59,977] INFO [Controller id=0] Broker failure callback for 1 (kafka.controller.KafkaController)
[2018-10-23 12:19:59,977] INFO [Controller id=0] Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController)

Looking at https://github.com/apache/kafka/blob/a947fe8da8646058335ff76b9a744462a3337a63/core/src/main/scala/kafka/controller/KafkaController.scala#L414 I'd guess there's a deadBrokersThatWereShuttingDown.mkString(",") missing, but my Scala-foo is too weak.

Issue Links

• links to: GitHub Pull Request #5831