Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-7498

common.requests.CreatePartitionsRequest uses clients.admin.NewPartitions

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0
    • Component/s: clients
    • Labels:
      None

      Description

      `org.apache.kafka.common.requests.CreatePartitionsRequest` currently uses `org.apache.kafka.clients.admin.NewPartitions`. We shouldn't have references from `common` to `clients`. Since `org.apache.kafka.clients.admin` is a public package, we cannot use a common class for Admin API and requests. So we should do something similar to CreateTopicsRequest for which we have `org.apache.kafka.clients.admin.NewTopic` class used for the admin API and an equivalent `org.apache.kafka.common.requests.CreateTopicsRequest.TopicDetails` class that doesn't refer to `clients.admin`.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rsivaram Rajini Sivaram
                Reporter:
                rsivaram Rajini Sivaram
                Reviewer:
                Ismael Juma
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: