[KAFKA-7351] Wrong logic in method ClusterConnectionStates.isDisconnected

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Component/s: clients
• Assignee: Unassigned
• Reporter: Boris Zhguchev
• Created: 28/Aug/18 10:56
• Updated: 08/Sep/18 06:13

Description

I think the method 

org.apache.kafka.clients.ClusterConnectionStates.isDisconnected

has wrong logic in proccesing wrong ids.

@Before
public void setup() {
    this.connectionStates = new ClusterConnectionStates(10_000, 60_000);
}

@Test
public void testIsDisconnected(){
    boolean connected = connectionStates.isConnected("fake_node");
    boolean disconnected = connectionStates.isDisconnected("fake_node");

    assertFalse(connected); // false
    assertFalse(disconnected); // false
}

It can be related with that that code block:

public boolean isDisconnected(String id) {
  NodeConnectionState state = nodeState.get(id);
// may be better is state == null ? true : state.isDisconnected()
  return state != null && state.state.isDisconnected(); 
}

link to github

Issue Links

• links to: GitHub Pull Request #5621