[KAFKA-7266] Fix MetricsTest test flakiness

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.1.0, 2.2.0
• Assignee: Stanislav Kozlovski
• Reporter: Stanislav Kozlovski
• Created: 09/Aug/18 12:47
• Updated: 05/Oct/18 17:06
• Resolved: 05/Oct/18 16:22

Description

The test `kafka.api.MetricsTest.testMetrics` has been failing intermittently in kafka builds (recent proof: https://github.com/apache/kafka/pull/5436#issuecomment-409683955)
The particular failure is in the `MessageConversionsTimeMs` metric assertion -

java.lang.AssertionError: Message conversion time not recorded 0.0

There has been work done previously (https://github.com/apache/kafka/pull/4681) to combat the flakiness of the test and while it has improved it, the test still fails sometimes.

Solution

On my machine, the test failed 5 times out of 25 runs. Increasing the record size and using compression should slow down message conversion enough to have it be above 1ms. Locally this test has not failed in 200 runs and counting with those changes

Issue Links

• links to: GitHub Pull Request #5485