[KAFKA-7237] Add explicit fatal marker to fatal error messages

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: core
• Assignee: Stanislav Kozlovski
• Reporter: Rajini Sivaram
• Created: 02/Aug/18 09:40
• Updated: 02/Aug/18 10:14

Description

We currently use FATAL markers for fatal error messages in core. But only logback supports markers out-of-the-box and log4j simply logs these as ERROR messages, ignoring the marker. We should perhaps include a String marker within these messages to make it easier to identify fatal messages in logs.

From https://www.slf4j.org/faq.html:

While markers are part of the SLF4J API, only logback supports markers off the shelf. For example, if you add the %marker}}conversion word to its pattern, logback's {{PatternLayout will add marker data to its output. Marker data can be used to filter messages or even trigger an outgoing email at the end of an individual transaction.

In combination with logging frameworks such as log4j and java.util.logging which do not support markers, marker data will be silently ignored.

Issue Links

• links to: GitHub Pull Request #5447