[KAFKA-7231] NetworkClient.newClientRequest() ignores custom request timeout in favor of the default

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.1, 2.1.0
• Component/s: clients
• Assignee: Jason Gustafson
• Reporter: Ron Dagostino
• Created: 01/Aug/18 19:27
• Updated: 21/Nov/18 22:17
• Resolved: 21/Nov/18 22:17

Description

The below code in org.apache.kafka.clients.KafkaClient is not passing in the provided requestTimeoutMs – it is ignoring it in favor of the defaultRequestTimeoutMs value.

@Override
public ClientRequest newClientRequest(String nodeId,
                                      AbstractRequest.Builder<?> requestBuilder,
                                      long createdTimeMs,
                                      boolean expectResponse,
                                      int requestTimeoutMs,
                                      RequestCompletionHandler callback) {
     return new ClientRequest(nodeId, requestBuilder, correlation++, clientId, createdTimeMs, expectResponse,
            defaultRequestTimeoutMs, callback);
}

This is an easy fix, but the impact of fixing it is difficult to quantify. Clients that set a custom timeout are getting the default timeout – fixing this will suddenly cause the custom timeout to take effect.

Issue Links

• links to: GitHub Pull Request #5444