Kafka
  1. Kafka
  2. KAFKA-688

System Test - Update all testcase_xxxx_properties.json for properties keys uniform naming convention

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None

      Description

      After the changes made in "uniform naming convention of properties keys" (KAFKA-648), all testcase_xxxx_properties.json files need to be updated on the following properties keys changes:

      brokerid => broker.id
      log.file.size => log.segment.size
      groupid => group.id

      1. kafka-688-v2.patch
        187 kB
        John Fung
      2. kafka-688-v1.patch
        188 kB
        John Fung

        Activity

        John Fung made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.8 [ 12317244 ]
        Resolution Fixed [ 1 ]
        Hide
        Jun Rao added a comment -

        Thanks for patch v2. Committed to 0.8 and merged to trunk.

        Show
        Jun Rao added a comment - Thanks for patch v2. Committed to 0.8 and merged to trunk.
        John Fung made changes -
        Attachment kafka-688-v2.patch [ 12564785 ]
        Hide
        John Fung added a comment -

        Uploaded kafka-688-v2.patch to revert the change of log.file.size => log.segment.file in Migration Tool Testcases in the 0.7 client sections.

        Show
        John Fung added a comment - Uploaded kafka-688-v2.patch to revert the change of log.file.size => log.segment.file in Migration Tool Testcases in the 0.7 client sections.
        John Fung made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        John Fung added a comment -

        Uploaded kafka-688-v1.patch which is required after checking in the patch in KAFKA-648.

        The changes include:

        1. Updated all testcase_xxxx_properties.json on the following properties keys:
        brokerid => broker.id
        log.file.size => log.segment.size
        groupid => group.id

        2. Added "07_client" property to migration_tool_testsuite/testcase_xxxx/testcase_xxxx_properties.json files under those brokers running in 0.7 code

        3. Modified system_test/utils/kafka_system_test_utils.py to add "brokerid" key to server.properties file if the broker is running under 0.7

        Show
        John Fung added a comment - Uploaded kafka-688-v1.patch which is required after checking in the patch in KAFKA-648 . The changes include: 1. Updated all testcase_xxxx_properties.json on the following properties keys: brokerid => broker.id log.file.size => log.segment.size groupid => group.id 2. Added "07_client" property to migration_tool_testsuite/testcase_xxxx/testcase_xxxx_properties.json files under those brokers running in 0.7 code 3. Modified system_test/utils/kafka_system_test_utils.py to add "brokerid" key to server.properties file if the broker is running under 0.7
        John Fung made changes -
        Attachment kafka-688-v1.patch [ 12564002 ]
        John Fung made changes -
        Description After the changes made in "uniform naming convention of properties keys" (KAFKA-648), all testcase_xxxx_properties.json files need to be updated on the following properties keys changes:

        brokerid => broker.id
        hostname => host.name
        log.file.size => log.segment.size
        groupid => group.id
        After the changes made in "uniform naming convention of properties keys" (KAFKA-648), all testcase_xxxx_properties.json files need to be updated on the following properties keys changes:

        brokerid => broker.id
        log.file.size => log.segment.size
        groupid => group.id
        John Fung made changes -
        Field Original Value New Value
        Description After the changes made in "uniform naming convention of properties keys" (KAFKA-648), all testcase_xxxx_properties.json files need to be updated on the following properties keys changes:

        brokerid => broker.id
        hostname => host.name
        log.file.size => log.segment.size
        After the changes made in "uniform naming convention of properties keys" (KAFKA-648), all testcase_xxxx_properties.json files need to be updated on the following properties keys changes:

        brokerid => broker.id
        hostname => host.name
        log.file.size => log.segment.size
        groupid => group.id
        John Fung created issue -

          People

          • Assignee:
            John Fung
            Reporter:
            John Fung
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development