[KAFKA-6731] waitOnState waits for the wrong state instead of the target one

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: streams
• Assignee: huxihx
• Reporter: huxihx
• Created: 01/Apr/18 10:53
• Updated: 25/Apr/18 09:42
• Resolved: 02/Apr/18 03:37

Description

In KafkaStreams.waitOnState, the code waits the state to be set to NOT_RUNNING instead of the given target state. Is it deliberately as designed?

// ......
while (state != State.NOT_RUNNING) {
    if (waitMs == 0) {
        try {
            stateLock.wait();
        } catch (final InterruptedException e) {
            // it is ok: just move on to the next iteration
        }
    } else if (waitMs > elapsedMs) {
        long remainingMs = waitMs - elapsedMs;
        try {
            stateLock.wait(remainingMs);
        } catch (final InterruptedException e) {
            // it is ok: just move on to the next iteration
        }
    } else {
        log.debug("Cannot transit to {} within {}ms", targetState, waitMs);
        return false;
    }
    elapsedMs = time.milliseconds() - begin;
}
return true;

IMO, it should check the state to be the target one. 

guozhang Does is make sense?

Issue Links

• links to: GitHub Pull Request #4808