[KAFKA-6561] Change visibility of aclMatch in SimpleAclAuthorizer to protected to allow overriding in subclasses

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.0.0
• Component/s: core
• Assignee: Sönke Liebau
• Reporter: Sönke Liebau
• Reviewer: Colin McCabe
• Created: 13/Feb/18 23:27
• Updated: 27/Feb/18 15:42
• Resolved: 27/Feb/18 15:42

Description

Currently the visibility of the aclMatch function in the SimpleAclAuthorizer class is set to private, thus prohibiting subclasses from overriding this method. I think this was originally done as this function is not supposed to be part of the public Api of this class, which makes sense.
However when creating a custom authorizer this would be a very useful method to override, as it allows to reuse a large amount of boilerplate code around loading and applying ACLs and simply changing the way that ACLs are matched.

Could we change the visibility of this method to protected, thus still keeping it out of the public interface but allowing for subclasses to override it?

Issue Links

• links to: GitHub Pull Request #4571