[KAFKA-6298] Line numbers on log messages are incorrect

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Assignee: Narendra Kumar
• Reporter: Colin McCabe
• Reviewer: Jason Gustafson
• Created: 02/Dec/17 00:03
• Updated: 04/Jan/18 17:00
• Resolved: 04/Jan/18 17:00

Description

The line numbers on log messages are all incorrect now.

For example, AdminClient should have this log message on line 394:

394 log.debug("Kafka admin client initialized")

But instead, it shows up as being on line 177:

    [2017-12-01 15:42:18,710] DEBUG [AdminClient clientId=adminclient-1] Kafka admin client initialized (org.apache.kafka.clients.admin.KafkaAdminClient:177)

The line numbers appear to be coming from LogContext.java:

174        @Override
175        public void debug(String message) {
176            if (logger.isDebugEnabled())
177                logger.debug(logPrefix + message);
178        }

Issue Links

• relates to: KAFKA-4710 Logging trait breaking logging location information retrival by log4j
• links to: GitHub Pull Request #4311
• links to: GitHub Pull Request #4311