[KAFKA-6218] Optimize condition in if statement to reduce the number of comparisons

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.9.0.0, 0.9.0.1, 0.10.0.0, 0.10.0.1, 0.10.1.0, 0.10.1.1, 0.10.2.0, 0.10.2.1, 0.11.0.0, 0.11.0.1, 1.0.0
• Fix Version/s: 1.1.0
• Component/s: connect
• Labels: newbie
• Assignee: sachin bhalekar
• Reporter: sachin bhalekar
• Reviewer: Ewen Cheslack-Postava
• Created: 16/Nov/17 03:14
• Updated: 16/Nov/17 23:08
• Resolved: 16/Nov/17 23:07

Description

Optimizing the condition in *if *statement
(schema.name() == null || !(schema.name().equals(LOGICAL_NAME))) which
requires two comparisons in worst case with
(!LOGICAL_NAME.equals(schema.name())) which requires single comparison
in all cases and avoids null pointer exception.

Issue Links

• links to: GitHub Pull Request #4225