[KAFKA-6172] Cache lastEntry in TimeIndex to avoid unnecessary disk access

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.1
• Assignee: Dong Lin
• Reporter: Dong Lin
• Created: 05/Nov/17 07:17
• Updated: 06/Mar/18 23:33
• Resolved: 06/Nov/17 22:07

Description

LogSegment.close() calls timeIndex.maybeAppend(...), which in turns make a number of calls to timeIndex.lastEntry(). Currently timeIndex.lastEntry() involves disk seek operation because it tries to read the content of the last few bytes of the index files on the disk. This slows down the broker shutdown process.

Here is the time of LogManager.shutdown() in various settings. In all these tests, broker has roughly 6k partitions and 20k segments.

• If broker does not have this patch and `log.dirs` is configured with 1 JBOD log directory, LogManager.shutdown() takes 15 minutes (roughly 900 seconds).

• If broker does not have this patch and `log.dirs` is configured with 10 JBOD log directories, LogManager.shutdown() takes 84 seconds.

• If broker have this patch and `log.dirs` is configured with 10 JBOD log directories, LogManager.shutdown() takes 24 seconds.

Thus we expect to save 71% time in LogManager.shutdown() by having this optimization. This patch intends to reduce the broker shutdown time by caching the lastEntry in memory so that broker does not have to always read disk to get the lastEntry.

Issue Links

• links to: GitHub Pull Request #4177