[KAFKA-6125] Avoid third party exception to flow through streams code base

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Component/s: streams
• Labels: streams-exception-handling
• Assignee: Unassigned
• Reporter: Matthias J. Sax
• Created: 25/Oct/17 23:32
• Updated: 15/May/20 02:19
• Resolved: 15/May/20 02:19

Description

Streams uses multiple internal client that might throw fatal exceptions (some should actually never occur, and if, this would indicate a bug).

We should wrap all calls to the used clients with a try-catch, and log those exceptions as ERRORs immediately. For exceptions that can only occur due to a bug (e.g., IllegalStateException, IllegalArgumentException, WakeupException, InterruptException) we should ask users in the log message to report this as a bug.

Last, we rethrow all those exceptions as StreamsException (to avoid that a standard library exception might be caught by accident somewhere else in our code base).