[KAFKA-5485] Streams should not suspend tasks twice

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 0.11.0.1, 1.0.0
• Component/s: streams
• Assignee: Matthias J. Sax
• Reporter: Matthias J. Sax
• Created: 21/Jun/17 02:07
• Updated: 30/Jun/17 07:58
• Resolved: 30/Jun/17 07:57

Description

Currently, Streams suspends tasks on rebalance and closes suspended tasks if not reassigned. During close, suspend() is called a second time, also calling Processor.close() for all nodes again.

It would be safer to only call suspend() once in case users have non-idempotent operations in Processor.close() method and might thus fail. (cf. KAFKA-5167)

Issue Links

• contains: KAFKA-5145 Remove task close() call from closeNonAssignedSuspendedTasks method
• incorporates: KAFKA-5167 streams task gets stuck after re-balance due to LockException
• links to: GitHub Pull Request #3390