Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      metrics 3.0.0 fixes some issues with the csv reporter that affect 0.8

      E.g., with metrics 2.1.3 we would just have NumDelayedRequests.csv but with 3.0.0 we would have kafka.server.ProducerRequestPurgatory.NumDelayedRequests.csv and kafka.server.FetchRequestPurgatory.NumDelayedRequests.csv

        Issue Links

          Activity

          Hide
          Joel Koshy added a comment -

          Patch overview:

          1 - I sent a mail to metrics-user group asking when 3.0.0 will be made
          available in mvn central. For now, I just did a local build off this:
          https://github.com/codahale/metrics.git -
          10ccc80c0f574f104c4745a1ffa24af0ea92efbf
          Added metrics-annotation-3.0.0-10ccc80c0.jar
          metrics-core-3.0.0-10ccc80c0.jar to core/lib (which cannot be included in
          the diff).
          2 - Made couple of changes due to slight differences in 3.0.0 API.
          3 - Fixed a small bug in the CSV reporter startup.
          4 - Provided a sample config in server.properties.

          Show
          Joel Koshy added a comment - Patch overview: 1 - I sent a mail to metrics-user group asking when 3.0.0 will be made available in mvn central. For now, I just did a local build off this: https://github.com/codahale/metrics.git - 10ccc80c0f574f104c4745a1ffa24af0ea92efbf Added metrics-annotation-3.0.0-10ccc80c0.jar metrics-core-3.0.0-10ccc80c0.jar to core/lib (which cannot be included in the diff). 2 - Made couple of changes due to slight differences in 3.0.0 API. 3 - Fixed a small bug in the CSV reporter startup. 4 - Provided a sample config in server.properties.
          Hide
          Joel Koshy added a comment -

          I heard back from metrics-user that there is no immediate plan to release 3.0.0, so I think we should move forward with this change.

          Show
          Joel Koshy added a comment - I heard back from metrics-user that there is no immediate plan to release 3.0.0, so I think we should move forward with this change.
          Hide
          Neha Narkhede added a comment -

          +1. Thanks for the patch !

          Show
          Neha Narkhede added a comment - +1. Thanks for the patch !
          Hide
          Joel Koshy added a comment -

          Thanks for the review. Committed to 0.8.

          Show
          Joel Koshy added a comment - Thanks for the review. Committed to 0.8.

            People

            • Assignee:
              Joel Koshy
              Reporter:
              Joel Koshy
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development