Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-523

OffsetRequest handler does not handle errors

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.1
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      There is not error handling in the KafkaRequestHandlers#handleOffsetRequest, as a result invalid requests get no data back since they raise an Exception in the server.

        Activity

        Hide
        guozhang Guozhang Wang added a comment -

        I think this issue has already been fixed in handleListOffsetRequest. Closing for now.

        Show
        guozhang Guozhang Wang added a comment - I think this issue has already been fixed in handleListOffsetRequest . Closing for now.
        Hide
        jozi-k Jozef Koval added a comment -

        The specified method does not exist anymore. Does it mean this issue can be closed?

        Show
        jozi-k Jozef Koval added a comment - The specified method does not exist anymore. Does it mean this issue can be closed?
        Hide
        jjkoshy Joel Koshy added a comment -

        This will be addressed as part of KAFKA-501. It requires a wire-format change though so it will be in 0.8.

        Show
        jjkoshy Joel Koshy added a comment - This will be addressed as part of KAFKA-501 . It requires a wire-format change though so it will be in 0.8.
        Hide
        mumrah David Arthur added a comment - - edited

        E.g., I make an OffsetRequest for an invalid partition I get no response on the client side, and I see the following exception in Kafka server logs:

            kafka.common.InvalidPartitionException: wrong partition 10
              at kafka.log.LogManager.getOrCreateLog(LogManager.scala:169)
              at kafka.server.KafkaRequestHandlers.handleOffsetRequest(KafkaRequestHandlers.scala:130)
              at kafka.server.KafkaRequestHandlers$$anonfun$handlerFor$5.apply(KafkaRequestHandlers.scala:47)
              at kafka.server.KafkaRequestHandlers$$anonfun$handlerFor$5.apply(KafkaRequestHandlers.scala:47)
              at kafka.network.Processor.handle(SocketServer.scala:289)
              at kafka.network.Processor.read(SocketServer.scala:312)
              at kafka.network.Processor.run(SocketServer.scala:207)
              at java.lang.Thread.run(Thread.java:680)
        
        Show
        mumrah David Arthur added a comment - - edited E.g., I make an OffsetRequest for an invalid partition I get no response on the client side, and I see the following exception in Kafka server logs: kafka.common.InvalidPartitionException: wrong partition 10 at kafka.log.LogManager.getOrCreateLog(LogManager.scala:169) at kafka.server.KafkaRequestHandlers.handleOffsetRequest(KafkaRequestHandlers.scala:130) at kafka.server.KafkaRequestHandlers$$anonfun$handlerFor$5.apply(KafkaRequestHandlers.scala:47) at kafka.server.KafkaRequestHandlers$$anonfun$handlerFor$5.apply(KafkaRequestHandlers.scala:47) at kafka.network.Processor.handle(SocketServer.scala:289) at kafka.network.Processor.read(SocketServer.scala:312) at kafka.network.Processor.run(SocketServer.scala:207) at java.lang. Thread .run( Thread .java:680)

          People

          • Assignee:
            Unassigned
            Reporter:
            mumrah David Arthur
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development