[KAFKA-4987] Topic creation allows invalid config values on running brokers

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.10.0.1, 0.10.1.0
• Component/s: config
• Assignee: Unassigned
• Reporter: dan norwood
• Created: 30/Mar/17 21:04
• Updated: 03/Aug/18 21:01

Description

we use kip4 capabilities to make a `CreateTopicsRequest` for our topics. one of the configs we use is `cleanup.policy=compact, delete`. this was inadvertently run against a cluster that does not support that policy. the result was that the topic was created, however on subsequent broker bounce the broker fails to start up

[2017-03-23 00:00:44,837] FATAL Fatal error during KafkaServer startup. Prepare to shutdown (kafka.server.KafkaServer)
org.apache.kafka.common.config.ConfigException: Invalid value compact,delete for configuration cleanup.policy: String must be one of: compact, delete
	at org.apache.kafka.common.config.ConfigDef$ValidString.ensureValid(ConfigDef.java:827)
	at org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:427)
	at org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:55)
	at kafka.log.LogConfig.<init>(LogConfig.scala:56)
	at kafka.log.LogConfig$.fromProps(LogConfig.scala:192)
	at kafka.server.KafkaServer$$anonfun$3.apply(KafkaServer.scala:598)
	at kafka.server.KafkaServer$$anonfun$3.apply(KafkaServer.scala:597)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.immutable.HashMap$HashMap1.foreach(HashMap.scala:224)
	at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:403)
	at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:403)
	at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:403)
	at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
	at scala.collection.AbstractTraversable.map(Traversable.scala:105)
	at kafka.server.KafkaServer.createLogManager(KafkaServer.scala:597)
	at kafka.server.KafkaServer.startup(KafkaServer.scala:183)
	at kafka.server.KafkaServerStartable.startup(KafkaServerStartable.scala:37)
	at kafka.Kafka$.main(Kafka.scala:67)
	at kafka.Kafka.main(Kafka.scala)
[2017-03-23 00:00:44,839] INFO shutting down (kafka.server.KafkaServer)
[2017-03-23 00:00:44,844] INFO shut down completed (kafka.server.KafkaServer)

i believe that the broker should fail when given an invalid config during topic creation