Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-4829

Improve logging of StreamTask commits

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.2.0
    • Fix Version/s: 0.11.0.0
    • Component/s: streams
    • Labels:

      Description

      Currently I see this every commit interval:

      2017-02-28T21:27:16.659Z INFO <> [StreamThread-1] o.a.k.s.p.internals.StreamThread - stream-thread [StreamThread-1] Committing task StreamTask 1_31
      2017-02-28T21:27:16.659Z INFO <> [StreamThread-1] o.a.k.s.p.internals.StreamThread - stream-thread [StreamThread-1] Committing task StreamTask 2_31
      

      We have ~10 tasks in our topology, 4 topics, and 32 partitions per topic.
      This means every commit interval we log a few hundred lines of the above
      which is an order of magnitude chattier than anything else in the log
      during normal operations.

      To improve visibility of important messages, we should reduce the chattiness of normal commits and highlight abnormal commits. An example proposal:

      existing message is fine at TRACE level for diagnostics
      TRACE o.a.k.s.p.i.StreamThread - Committing task StreamTask 1_31

      normal fast case, wrap them all up into one summary line
      INFO o.a.k.s.p.i.StreamThreads - 64 stream tasks committed in 25ms

      some kind of threshold / messaging in case it doesn't complete quickly or logs an exception
      ERROR o.a.k.s.p.i.StreamThread - StreamTask 1_32 did not commit in 100ms

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                guozhang Guozhang Wang
                Reporter:
                stevenschlansker Steven Schlansker
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: