[KAFKA-456] ProducerSendThread calls ListBuffer.size a whole bunch. That is a O(n) operation

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 0.8.0
• Component/s: core
• Labels: newbie
• Environment: NA
• Assignee: David Arthur
• Reporter: Matthew Rathbone
• Created: 09/Aug/12 22:42
• Updated: 19/Jun/14 05:11
• Resolved: 04/Oct/12 17:32

Description

Hi all,

So there are various statements throughout the async code that call 'events.size', mostly for debugging purposes.
Problem is that this call is O, so it could add up if the batch size is high. (it's a ListBuffer)

I see this in at least ProducerSendThread (x4), likely more. Will factor this out myself soon when I start hacking on the project, just wanted to put this somewhere.