[KAFKA-4172] Fix masked test error in KafkaConsumerTest.testSubscriptionChangesWithAutoCommitEnabled

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.1.0
• Component/s: consumer, unit tests
• Assignee: Jason Gustafson
• Reporter: Jason Gustafson
• Created: 14/Sep/16 23:56
• Updated: 15/Sep/16 01:05
• Resolved: 15/Sep/16 01:05

Description

This test case has an incorrectly matched mock fetch response, which was silently raising an NPE, which was caught in NetworkClient. In general, aside from fixing the test, we are probably missing a null check in the FetchRespose to verify that the partitions included in the fetch response were actually requested. This is usually not a problem because the broker doesn't send us invalid fetch responses, but it's probably better to be a little more defensive when handling responses.

Issue Links

• links to: GitHub Pull Request #1857