Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-4172

Fix masked test error in KafkaConsumerTest.testSubscriptionChangesWithAutoCommitEnabled

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.1.0
    • Component/s: consumer, unit tests
    • Labels:
      None

      Description

      This test case has an incorrectly matched mock fetch response, which was silently raising an NPE, which was caught in NetworkClient. In general, aside from fixing the test, we are probably missing a null check in the FetchRespose to verify that the partitions included in the fetch response were actually requested. This is usually not a problem because the broker doesn't send us invalid fetch responses, but it's probably better to be a little more defensive when handling responses.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hachikuji Jason Gustafson
                Reporter:
                hachikuji Jason Gustafson
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: