[KAFKA-354] Refactor getter and setter API to conform to the new convention

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 0.8.0
• Labels: optimization
• Assignee: Joe Stein
• Reporter: Neha Narkhede
• Created: 31/May/12 22:39
• Updated: 30/Oct/17 12:18
• Resolved: 30/Oct/17 12:18

Description

We just agreed on a new convention for getter/setter APIs. It will be good to refactor code to conform to that.

> We can actually go with public vals or vars - there is not much point in
> defining a custom getter/setter as that is redundant.
>
> For example:
> - start with "val x"
> - over time, we determine that it needs to be mutable - change it to "var
> x"
> - if you need something more custom (e.g., enforce constraints on the
> values that you can assign) then we can add the custom setter
> private[this] var underyling: T = ...
> def x = underlying
> def x_=(update: T) { if (constraint satisfied)

{underlying = update}

> else

{throw new Exception}

}
>
> All of the above changes will be binary compatible since under the covers,
> reads/assignments are all through getter/setter methods.