[KAFKA-3533] Kafka Consumer Config validation should be AND not OR

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Labels: Newbie
• Assignee: Unassigned
• Reporter: Ryan P
• Created: 08/Apr/16 18:14
• Updated: 08/Apr/16 19:49
• Resolved: 08/Apr/16 19:19

Description

There seems to be a bit of an inconsistency between between the configuration validation imposed in the KafkaConsumer class and the error message presented:

https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L556-L557

Based on the error message the request timeout should be greater than the session timeout and the max fetch wait timeout. The validation logic however checks to ensure that either operand is true, not both.

In the event that your request timeout is greater than the session timeout the operation will be short-circuited allowing for a potential misconfiguration of the consumer.

Based on what I can tell the error message is correct and the validation check is incorrect.