• Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s:
    • Component/s: core
    • Labels:


      We seem to be accumulating a bunch of unnecessary classes that implement Send. I am not sure why people are doing this. Example:

      It is not at all clear why we would add a custom send object for each request/response type. They all do the same thing. The only reason for having the concept of a Send object was to allow two implementations: ByteBufferSend and MessageSetSend, the later let's us abstract over the difference between a normal write and a sendfile() call.

      I think we can refactory ByteBufferSend to take one or more ByteBuffers instead of just one and delete all of these one-offs.


        Jay Kreps created issue -
        Neha Narkhede made changes -
        Field Original Value New Value
        Labels replication
        Joe Stein made changes -
        Fix Version/s 0.8.1 [ 12322960 ]
        Fix Version/s 0.8 [ 12317244 ]
        Neha Narkhede made changes -
        Fix Version/s 0.9.0 [ 12323928 ]
        Fix Version/s 0.8.1 [ 12322960 ]
        Jay Kreps added a comment -

        This was fixed a long while back, cleaning up.

        Jay Kreps added a comment - This was fixed a long while back, cleaning up.
        Jay Kreps made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Tony Stevenson made changes -
        Workflow no-reopen-closed, patch-avail [ 12660137 ] Apache Kafka Workflow [ 13050924 ]
        Tony Stevenson made changes -
        Workflow Apache Kafka Workflow [ 13050924 ] no-reopen-closed, patch-avail [ 13053392 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        844d 15h 33m 1 Jay Kreps 21/Jul/14 22:47


          • Assignee:
            Jay Kreps
            Jay Kreps
          • Votes:
            0 Vote for this issue
            1 Start watching this issue


            • Created: