Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0.0
    • Component/s: core
    • Labels:

      Description

      We seem to be accumulating a bunch of unnecessary classes that implement Send. I am not sure why people are doing this. Example:
      ProducerResponseSend.scala

      It is not at all clear why we would add a custom send object for each request/response type. They all do the same thing. The only reason for having the concept of a Send object was to allow two implementations: ByteBufferSend and MessageSetSend, the later let's us abstract over the difference between a normal write and a sendfile() call.

      I think we can refactory ByteBufferSend to take one or more ByteBuffers instead of just one and delete all of these one-offs.

        Attachments

          Activity

            People

            • Assignee:
              jkreps Jay Kreps
              Reporter:
              jkreps Jay Kreps
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: