Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-316

disallow recursively compressed message

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      Currently, it is possible to create a compressed Message that contains a set of Messages, each of which is further compressed. Support recursively compressed messages has little benefit and can complicates the on disk storage format. We should probably disallow this.

        Activity

        Hide
        omkreddy Manikumar added a comment -

        This was fixed in newer Kafka versions using client-side MemoryRecords/related code. Related JIRA : KAFKA-2066, KAFKA-1739

        Show
        omkreddy Manikumar added a comment - This was fixed in newer Kafka versions using client-side MemoryRecords/related code. Related JIRA : KAFKA-2066 , KAFKA-1739
        Hide
        mumrah David Arthur added a comment -

        In addition to the reasons citing in the description, it makes client message decoding more complex. I'm not sure what reason there would be to keep it.

        Show
        mumrah David Arthur added a comment - In addition to the reasons citing in the description, it makes client message decoding more complex. I'm not sure what reason there would be to keep it.
        Hide
        sriramsub Sriram Subramanian added a comment -

        I don't see any reason to prevent nested messages. Do we need to fix this?

        Show
        sriramsub Sriram Subramanian added a comment - I don't see any reason to prevent nested messages. Do we need to fix this?
        Hide
        mumrah David Arthur added a comment -

        Add a "depth" variable to keep track of recursion level. If depth > 0, throw an InvalidMessageException

        Show
        mumrah David Arthur added a comment - Add a "depth" variable to keep track of recursion level. If depth > 0, throw an InvalidMessageException

          People

          • Assignee:
            Unassigned
            Reporter:
            junrao Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development