Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-3100

Broker.createBroker should work if json is version > 2, but still compatible

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0.0
    • Fix Version/s: 0.9.0.1
    • Component/s: core
    • Labels:
      None

      Description

      Description from Jun:

      In 0.9.0.0, the old consumer reads broker info directly from ZK and the code throws an exception if the version in json is not 1 or 2. This old consumer will break when we upgrade the broker json to version 3 in ZK in 0.9.1, which will be an issue. We overlooked this issue in 0.9.0.0. The easiest fix is probably not to check the version in ZkUtils.getBrokerInfo().

      This way, as long as we are only adding new fields in broker json, we can preserve the compatibility.

        Attachments

          Activity

            People

            • Assignee:
              ijuma Ismael Juma
              Reporter:
              ijuma Ismael Juma
              Reviewer:
              Jun Rao
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: