Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      This JIRA will involve implementing the becomeLeader() and becomeFollower() APIs, as described in the Kafka replication design proposal. This can still be done independently of KAFKA-44

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          14d 1h 50m 1 Prashanth Menon 27/Mar/12 03:11
          In Progress In Progress Resolved Resolved
          75d 18h 30m 1 Neha Narkhede 10/Jun/12 21:41
          Neha Narkhede made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Assignee Prashanth Menon [ prashanth.menon ] Neha Narkhede [ nehanarkhede ]
          Resolution Fixed [ 1 ]
          Hide
          Neha Narkhede added a comment -

          Fixed as part of KAFKA-46

          Show
          Neha Narkhede added a comment - Fixed as part of KAFKA-46
          Hide
          Neha Narkhede added a comment -

          If you don't have a patch ready for submission, let me attempt to pull out changes related to this JIRA from KAFKA-46. It will hopefully make it easier to review it in pieces.

          Show
          Neha Narkhede added a comment - If you don't have a patch ready for submission, let me attempt to pull out changes related to this JIRA from KAFKA-46 . It will hopefully make it easier to review it in pieces.
          Hide
          Prashanth Menon added a comment -

          Oh boy, taking a look at the KAFKA-46 patch, it's pretty massive. At this point, it might be better/easier to review the section of KAFKA-46 that covers this ticket. I'll comment there.

          Show
          Prashanth Menon added a comment - Oh boy, taking a look at the KAFKA-46 patch, it's pretty massive. At this point, it might be better/easier to review the section of KAFKA-46 that covers this ticket. I'll comment there.
          Hide
          Prashanth Menon added a comment -

          So, I have to apologize on my tardiness; I had completed most of the work, but didn't get a chance to clean it up before submitting for review. What I'll do is tidy it up, and try to cherry-pick and psuedo-merge it with your implementation. Expect something this weekend.

          Show
          Prashanth Menon added a comment - So, I have to apologize on my tardiness; I had completed most of the work, but didn't get a chance to clean it up before submitting for review. What I'll do is tidy it up, and try to cherry-pick and psuedo-merge it with your implementation. Expect something this weekend.
          Neha Narkhede made changes -
          Link This issue blocks KAFKA-46 [ KAFKA-46 ]
          Hide
          Neha Narkhede added a comment -

          Prashanth,

          To get the work for KAFKA-46 going, I took a stab at the becomeLeader/becomeFollower() logic. I would appreciate if you could review it. If you already have a patch, we can reverse the order, and review your patch, get it checked in and then do the rest of the review for KAFKA-46. We can try not to waste any of the work you might've already put in, for this JIRA.

          Show
          Neha Narkhede added a comment - Prashanth, To get the work for KAFKA-46 going, I took a stab at the becomeLeader/becomeFollower() logic. I would appreciate if you could review it. If you already have a patch, we can reverse the order, and review your patch, get it checked in and then do the rest of the review for KAFKA-46 . We can try not to waste any of the work you might've already put in, for this JIRA.
          Hide
          Prashanth Menon added a comment -

          Hi folks. Now that KAFKA-301 has been committed, I'll begin taking a look at this. As usually, time is tight, but I'm hoping to get something in this weekend.

          Show
          Prashanth Menon added a comment - Hi folks. Now that KAFKA-301 has been committed, I'll begin taking a look at this. As usually, time is tight, but I'm hoping to get something in this weekend.
          Neha Narkhede made changes -
          Labels replication
          Hide
          Neha Narkhede added a comment -

          This JIRA implements the becomeLeader() and becomeFollower() APIs as listed here - https://cwiki.apache.org/confluence/display/KAFKA/Kafka+replication+detailed+design+V2#KafkareplicationdetaileddesignV2-Becomeleader.
          Since commit thread and replica fetcher thread is part of KAFKA-46, please leave empty stubs for those, in the patch for this JIRA.

          Show
          Neha Narkhede added a comment - This JIRA implements the becomeLeader() and becomeFollower() APIs as listed here - https://cwiki.apache.org/confluence/display/KAFKA/Kafka+replication+detailed+design+V2#KafkareplicationdetaileddesignV2-Becomeleader . Since commit thread and replica fetcher thread is part of KAFKA-46 , please leave empty stubs for those, in the patch for this JIRA.
          Hide
          Neha Narkhede added a comment -

          The work here would require KAFKA-301 to be completed.

          Show
          Neha Narkhede added a comment - The work here would require KAFKA-301 to be completed.
          Neha Narkhede made changes -
          Link This issue is blocked by KAFKA-301 [ KAFKA-301 ]
          Prashanth Menon made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Prashanth Menon made changes -
          Field Original Value New Value
          Assignee Prashanth Menon [ prashanth.menon ]
          Neha Narkhede created issue -

            People

            • Assignee:
              Neha Narkhede
              Reporter:
              Neha Narkhede
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development