Kafka
  1. Kafka
  2. KAFKA-296

Update Go Client to new version of Go

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.7.1
    • Fix Version/s: 0.8.0
    • Component/s: clients
    • Labels:
      None

      Description

      go (http://golang.org) is close to releasing a new release of go (1.0) which requires updates to the client, in the meantime most of the go community has moved to this version.

      This change contains:

      • language changes to existing client (os.Error, time. Signals, etc)
      • removes the Makefile's (no longer used by go)
      • It also runs "go fmt" (formats it in standard go) which are most of the lines changes, from spaces to tabs.
      • updates the import path to allow for "go get" installs (don't need to get source and build)

      Not sure which versions this should apply to, but i think it should go to 0.7 and newer.

      1. go1updates.patch
        68 kB
        AaronR
      2. kafka296-v2.patch
        14 kB
        AaronR
      3. kafka296v3.git.patch
        33 kB
        AaronR
      4. kafka296_v4.patch
        92 kB
        Jeffrey Damick

        Activity

        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Matt T. Proud made changes -
        Comment [ Question: Would it be well to up-integrate pomack's work, the one who originally created Golang support in Thrift, back into the mainline since a bunch of fixes have already gone into his repository. A number of folks already appear to be using this for Cassandra these days. Please see https://issues.apache.org/jira/browse/THRIFT-1600 for reference or to close one or the other as a duplicate.

        Either way, I do have a pull request on Github to mainline pomack's work: https://github.com/apache/thrift/pull/24. ]
        Joe Stein made changes -
        Fix Version/s 0.8 [ 12317244 ]
        Fix Version/s 0.7.1 [ 12319140 ]
        Jeffrey Damick made changes -
        Status Reopened [ 4 ] Patch Available [ 10002 ]
        Jeffrey Damick made changes -
        Attachment kafka296_v4.patch [ 12519674 ]
        Jun Rao made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.7.1 [ 12319140 ]
        Resolution Fixed [ 1 ]
        AaronR made changes -
        Attachment kafka296v3.git.patch [ 12518282 ]
        AaronR made changes -
        Attachment kafka296-v2.patch [ 12518072 ]
        AaronR made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.7.1 [ 12319140 ]
        AaronR made changes -
        Field Original Value New Value
        Attachment go1updates.patch [ 12517614 ]
        AaronR created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            AaronR
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development