Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-2740

Convert Windows bin scripts from CRLF to LF line encodings

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.8.2.1
    • 0.9.0.0
    • core
    • None

    Description

      We currently have an inconsistency with regards to line encodings of the Windows bin/ scripts. All but three Windows scripts use the same line encodings as we do for the rest of the code (LF aka Unix style).

      The three Windows scripts that use CRLF encoding (aka Windows style) are:

      • kafka-run-class.bat
      • kafka-server-stop.bat
      • zookeeper-server-stop.bat

      I'd suggest we convert the three scripts above from CRLF to LF. This will not only restore consistency, it will also (and more importantly) resolve woes caused by line encoding differences when diffing, patching, etc. these files/code.

      Attachments

        Activity

          People

            Unassigned Unassigned
            miguno Michael G. Noll
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: