[KAFKA-2605] Replace `catch: Throwable` clauses with `NonFatal` or `NonControl`

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.11.0.0, 1.0.0
• Labels: newbie
• Assignee: Jin Xing
• Reporter: Ismael Juma
• Created: 02/Oct/15 11:55
• Updated: 08/Nov/17 17:12

Description

The Kafka codebase includes a number of instances where we do `catch t: Throwable` where we should really be doing `catch NonFatal(t)` or `catch NonControl(t)` where `NonFatal` is part of the standard library and `NonControl` is something like:

object NonControl {
   def apply(t: Throwable): Boolean = t match {
     case _: ControlThrowable => false
     case _ => true
   }
  def unapply(t: Throwable): Option[Throwable] = if (apply(t)) Some(t) else None
}

We can also use `NonControl` to replace cases like (it's more concise and has the same behaviour):

  case e: ControlThrowable => throw e
  case e: Throwable => ...