Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1326 New consumer checklist
  3. KAFKA-2604

Remove `completeAll` and improve timeout passed to `Selector.poll` from `NetworkClient.poll`

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.9.0.0
    • consumer
    • None

    Description

      Now that KAFKA-2120 has been merged, we can improve a few things:

      1. Remove `NetworkClient.completeAll`
      2. Call `Selector.poll` with a timeout that is the minimum of timeout, metadata timeout and request timeout
      3. Disallow `Selector.poll(-1)` as it's not used and not something that we want generally (and one can always use `Selector.poll(Integer.MAX_VALUE)` if one really wants it

      Attachments

        Activity

          People

            ijuma Ismael Juma
            ijuma Ismael Juma
            Guozhang Wang Guozhang Wang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: