Kafka
  1. Kafka
  2. KAFKA-221

LICENSE and NOTICE problems in Kafka 0.7

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      The source LICENSE file for Kafka is incomplete. The LICENSE file needs to accurately reflect the Kafka source and included artifacts.

      Similarly, the NOTICE file is likely to be missing information. I'll attach a file with some information that I created. It's incomplete and will need additional work...

      1. kafka-221-4.patch
        8 kB
        Neha Narkhede
      2. KAFKA-221-3.patch
        7 kB
        Jakob Homan
      3. KAFKA-221-2.patch
        7 kB
        Jakob Homan
      4. KAFKA-221.patch
        6 kB
        Jakob Homan
      5. kafka-license-info.txt
        11 kB
        Kevan Miller

        Issue Links

          Activity

          Hide
          Kevan Miller added a comment -

          This is a partial analysis of Kafka LICENSE/NOTICE requirements. I use emacs to look inside jars for license/notice files. if you don't find one, then you need to search for a license for the artifact.

          Once you have this information pulled together, it's not too hard to pull it all into a LICENSE/NOTICE file.

          Unfortunately, there's just not a good automated way to generate this information. If it's any comfort, Geronimo has way more embedded jar files than Kafka...

          Show
          Kevan Miller added a comment - This is a partial analysis of Kafka LICENSE/NOTICE requirements. I use emacs to look inside jars for license/notice files. if you don't find one, then you need to search for a license for the artifact. Once you have this information pulled together, it's not too hard to pull it all into a LICENSE/NOTICE file. Unfortunately, there's just not a good automated way to generate this information. If it's any comfort, Geronimo has way more embedded jar files than Kafka...
          Hide
          Jakob Homan added a comment -

          Patch that re-does the LICENSE and NOTICE file assuming KAFKA-222 goes in. NOTICE now just has entries for LinkedIn's contribution, zkclient and sbt. The other remaining jars are from Apache projects and so don't need to be included here (per my understanding). The License file has Scala, sbt's license (copied from its LICENSE file in the release we use). zkclient is Apache licensed and as far as I can tell, it therefore doesn't need to be included here. Is this correct?

          Show
          Jakob Homan added a comment - Patch that re-does the LICENSE and NOTICE file assuming KAFKA-222 goes in. NOTICE now just has entries for LinkedIn's contribution, zkclient and sbt. The other remaining jars are from Apache projects and so don't need to be included here (per my understanding). The License file has Scala, sbt's license (copied from its LICENSE file in the release we use). zkclient is Apache licensed and as far as I can tell, it therefore doesn't need to be included here. Is this correct?
          Hide
          ant elder added a comment -

          I've tried to have a look but i don't have git and can't work out what SVN revision that patch is against so its hard for me to tell what the resultant files will look like, would you be able to attach the complete license and notice files here?

          What is the reasoning behind keeping the NOTICE file entries for LinkedIn, zkclient and sbt? For example, looking at the sbt license at https://github.com/harrah/xsbt/blob/0.11/LICENSE if you include that complete license text in the Kafka LICENSE file then I don't think there is a need to mention sbt in the Kafka NOTICE.

          Show
          ant elder added a comment - I've tried to have a look but i don't have git and can't work out what SVN revision that patch is against so its hard for me to tell what the resultant files will look like, would you be able to attach the complete license and notice files here? What is the reasoning behind keeping the NOTICE file entries for LinkedIn, zkclient and sbt? For example, looking at the sbt license at https://github.com/harrah/xsbt/blob/0.11/LICENSE if you include that complete license text in the Kafka LICENSE file then I don't think there is a need to mention sbt in the Kafka NOTICE.
          Hide
          Jakob Homan added a comment - - edited

          OK, updated based on comments from Ant and the other thread. NOTICE (new version: http://dl.dropbox.com/u/565949/NOTICE ) only contains the Apache notice based on:

          • as Ant mentioned, the sbt license is included in full in LICENSE so not necessary in NOTICE
          • zkclient is Apache 2.0 licensed (category A), so no need to mention it in LICENSE
            New LICENSE (new version: http://dl.dropbox.com/u/565949/LICENSE ):
          • Removed Scala license, since we're not distributing the Scala runtime (it's pulled in via sbt)
          • Has sbt license since it is being included and requires inclusion (although I still don't understand why including it in its jar isn't enough to satisfy this condition)
          • Doesn't include anything for zkclient since it's ASL2.0
          • Doesn't include anything for the pig stuff since they're sister ASF projects.

          I think this is enough for a source release.

          Show
          Jakob Homan added a comment - - edited OK, updated based on comments from Ant and the other thread. NOTICE (new version: http://dl.dropbox.com/u/565949/NOTICE ) only contains the Apache notice based on: as Ant mentioned, the sbt license is included in full in LICENSE so not necessary in NOTICE zkclient is Apache 2.0 licensed (category A), so no need to mention it in LICENSE New LICENSE (new version: http://dl.dropbox.com/u/565949/LICENSE ): Removed Scala license, since we're not distributing the Scala runtime (it's pulled in via sbt) Has sbt license since it is being included and requires inclusion (although I still don't understand why including it in its jar isn't enough to satisfy this condition) Doesn't include anything for zkclient since it's ASL2.0 Doesn't include anything for the pig stuff since they're sister ASF projects. I think this is enough for a source release.
          Hide
          Jakob Homan added a comment -

          re-submitting patch.

          Show
          Jakob Homan added a comment - re-submitting patch.
          Hide
          Jakob Homan added a comment -

          here's a new version without the final line of dashes in LICENSE.

          Show
          Jakob Homan added a comment - here's a new version without the final line of dashes in LICENSE.
          Hide
          Neha Narkhede added a comment -

          +1 on the latest patch.

          Show
          Neha Narkhede added a comment - +1 on the latest patch.
          Hide
          Neha Narkhede added a comment -

          I think we missed the nunit entry in the LICENSE and the NOTICE files. We have the nunit.dll checked into the source repository under clients/csharp

          Show
          Neha Narkhede added a comment - I think we missed the nunit entry in the LICENSE and the NOTICE files. We have the nunit.dll checked into the source repository under clients/csharp
          Hide
          Neha Narkhede added a comment -

          Thanks a bunch for helping out on this patch, Jakob !
          Just committed this.

          Show
          Neha Narkhede added a comment - Thanks a bunch for helping out on this patch, Jakob ! Just committed this.

            People

            • Assignee:
              Jakob Homan
              Reporter:
              Kevan Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development