Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-216

Add nunit license to the NOTICE file

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Blocker
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.7
        • Component/s: packaging
        • Labels:
          None

          Description

          According to yet some more feedback from general@, we need to add NUnit (http://www.nunit.org/) to the NOTICE file.

          1. Text File
            KAFKA-216.patch
            2 kB
            Jakob Homan
          2. Text File
            KAFKA-216-2.patch
            2 kB
            Jakob Homan

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jghoman Jakob Homan added a comment -

            Patch adds nunit verbage to NOTICE and text of zlib/libpng to LICENSE.

            Show
            jghoman Jakob Homan added a comment - Patch adds nunit verbage to NOTICE and text of zlib/libpng to LICENSE.
            Hide
            Permalink
            cburroughs Chris Burroughs added a comment -

            Could you add something like "For Nunit used in clients/foo/bar" to the LICENSE text so this is easier to make sense of? Otherwise looks good to me.

            Show
            cburroughs Chris Burroughs added a comment - Could you add something like "For Nunit used in clients/foo/bar" to the LICENSE text so this is easier to make sense of? Otherwise looks good to me.
            Hide
            Permalink
            nehanarkhede Neha Narkhede added a comment -

            Yeah, I think it will be useful to add "For Nunit used in clients/csharp" to the LICENSE file.

            Show
            nehanarkhede Neha Narkhede added a comment - Yeah, I think it will be useful to add "For Nunit used in clients/csharp" to the LICENSE file.
            Hide
            Permalink
            jghoman Jakob Homan added a comment -

            Updated with new nunit verbiage.

            Show
            jghoman Jakob Homan added a comment - Updated with new nunit verbiage.
            Hide
            Permalink
            nehanarkhede Neha Narkhede added a comment -

            +1.

            Show
            nehanarkhede Neha Narkhede added a comment - +1.
            Hide
            Permalink
            nehanarkhede Neha Narkhede added a comment -

            This should be double committed to the 0.7 branch, in addition to trunk

            Show
            nehanarkhede Neha Narkhede added a comment - This should be double committed to the 0.7 branch, in addition to trunk
            Hide
            Permalink
            jghoman Jakob Homan added a comment -

            Committed to trunk and 0.7. Resolving as fixed.

            Show
            jghoman Jakob Homan added a comment - Committed to trunk and 0.7. Resolving as fixed.

              People

              • Assignee:
                jghoman Jakob Homan
                Reporter:
                nehanarkhede Neha Narkhede
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development