Kafka
  1. Kafka
  2. KAFKA-216

Add nunit license to the NOTICE file

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: packaging
    • Labels:
      None

      Description

      According to yet some more feedback from general@, we need to add NUnit (http://www.nunit.org/) to the NOTICE file.

      1. KAFKA-216.patch
        2 kB
        Jakob Homan
      2. KAFKA-216-2.patch
        2 kB
        Jakob Homan

        Activity

        Neha Narkhede created issue -
        Hide
        Jakob Homan added a comment -

        Patch adds nunit verbage to NOTICE and text of zlib/libpng to LICENSE.

        Show
        Jakob Homan added a comment - Patch adds nunit verbage to NOTICE and text of zlib/libpng to LICENSE.
        Jakob Homan made changes -
        Field Original Value New Value
        Attachment KAFKA-216.patch [ 12505463 ]
        Jakob Homan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jakob Homan made changes -
        Assignee Jakob Homan [ jghoman ]
        Hide
        Chris Burroughs added a comment -

        Could you add something like "For Nunit used in clients/foo/bar" to the LICENSE text so this is easier to make sense of? Otherwise looks good to me.

        Show
        Chris Burroughs added a comment - Could you add something like "For Nunit used in clients/foo/bar" to the LICENSE text so this is easier to make sense of? Otherwise looks good to me.
        Hide
        Neha Narkhede added a comment -

        Yeah, I think it will be useful to add "For Nunit used in clients/csharp" to the LICENSE file.

        Show
        Neha Narkhede added a comment - Yeah, I think it will be useful to add "For Nunit used in clients/csharp" to the LICENSE file.
        Hide
        Jakob Homan added a comment -

        Updated with new nunit verbiage.

        Show
        Jakob Homan added a comment - Updated with new nunit verbiage.
        Jakob Homan made changes -
        Attachment KAFKA-216-2.patch [ 12505565 ]
        Hide
        Neha Narkhede added a comment -

        +1.

        Show
        Neha Narkhede added a comment - +1.
        Hide
        Neha Narkhede added a comment -

        This should be double committed to the 0.7 branch, in addition to trunk

        Show
        Neha Narkhede added a comment - This should be double committed to the 0.7 branch, in addition to trunk
        Hide
        Jakob Homan added a comment -

        Committed to trunk and 0.7. Resolving as fixed.

        Show
        Jakob Homan added a comment - Committed to trunk and 0.7. Resolving as fixed.
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4h 58m 1 Jakob Homan 29/Nov/11 08:18
        Patch Available Patch Available Resolved Resolved
        1d 15h 25m 1 Jakob Homan 30/Nov/11 23:43

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Neha Narkhede
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development