Kafka
  1. Kafka
  2. KAFKA-210

javaapi ZookeeperConsumerConnectorTest duplicates many tests in the scala version

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7.1
    • Component/s: core
    • Labels:
      None

      Description

      Since javaapi.ZookeeperConsumerConnector is just a thin wrapper over the scala version, we only need to test the basic functionality there.

        Activity

        Hide
        Jun Rao added a comment -

        Remove unnecessary duplicated test cases.

        Show
        Jun Rao added a comment - Remove unnecessary duplicated test cases.
        Hide
        Jay Kreps added a comment -

        Is this approach better than trying to abstract over the actual operations and having the test work against the abstraction? E.g. have BaseConsumerConnectorTest and have JavaConsumerConnectorTest and ScalaConsumerConnectorTest extend that to run the same operations against both clients. Or are you saying since we already test this stuff on the scala consumer there is no point doing the same thing on the java one since it is just a wrapper?

        Show
        Jay Kreps added a comment - Is this approach better than trying to abstract over the actual operations and having the test work against the abstraction? E.g. have BaseConsumerConnectorTest and have JavaConsumerConnectorTest and ScalaConsumerConnectorTest extend that to run the same operations against both clients. Or are you saying since we already test this stuff on the scala consumer there is no point doing the same thing on the java one since it is just a wrapper?
        Hide
        Jun Rao added a comment -

        Yes, I am saying that there is no need to stress test the javaapi since it's just a wrapper. All we need to test is that the java <-> scala conversion works. So one basic test should be enough for this purpose.

        Show
        Jun Rao added a comment - Yes, I am saying that there is no need to stress test the javaapi since it's just a wrapper. All we need to test is that the java <-> scala conversion works. So one basic test should be enough for this purpose.
        Hide
        Jay Kreps added a comment -

        Sounds good. +1

        Show
        Jay Kreps added a comment - Sounds good. +1
        Hide
        Jun Rao added a comment -

        committed

        Show
        Jun Rao added a comment - committed

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development