[KAFKA-204] BoundedByteBufferReceive hides OutOfMemoryError

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7.1
• Assignee: Chris Burroughs
• Reporter: Chris Burroughs
• Created: 15/Nov/11 16:31
• Updated: 23/Nov/11 23:46
• Resolved: 23/Nov/11 23:46

Description

private def byteBufferAllocate(size: Int): ByteBuffer = {
var buffer: ByteBuffer = null
try

{ buffer = ByteBuffer.allocate(size) }

catch

{ case e: OutOfMemoryError => throw new RuntimeException("OOME with size " + size, e) case e2 => throw e2 }

buffer
}

This hides the fact that an Error occurred, and will likely result in some log handler printing a message, instead of exiting with non-zero status. Knowing how large the allocation was that caused an OOM is really nice, so I'd suggest logging in byteBufferAllocate and then re-throwing OutOfMemoryError